From: Jeff Layton <jlayton@kernel.org>
Date: Fri, 19 Jul 2024 18:55:53 +0000 (-0400)
Subject: nfsd: don't set SVC_SOCK_ANONYMOUS when creating nfsd sockets
X-Git-Tag: v6.11-rc3~9^2
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=91da337e5d506f2c065d20529d105ca40090e320;p=linux-block.git

nfsd: don't set SVC_SOCK_ANONYMOUS when creating nfsd sockets

When creating nfsd sockets via the netlink interface, we do want to
register with the portmapper. Don't set SVC_SOCK_ANONYMOUS.

Reported-by: Steve Dickson <steved@redhat.com>
Fixes: 16a471177496 ("NFSD: add listener-{set,get} netlink command")
Cc: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---

diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
index 9e0ea6fc2aa3..34eb2c2cbcde 100644
--- a/fs/nfsd/nfsctl.c
+++ b/fs/nfsd/nfsctl.c
@@ -2069,8 +2069,7 @@ int nfsd_nl_listener_set_doit(struct sk_buff *skb, struct genl_info *info)
 			continue;
 		}
 
-		ret = svc_xprt_create_from_sa(serv, xcl_name, net, sa,
-					      SVC_SOCK_ANONYMOUS,
+		ret = svc_xprt_create_from_sa(serv, xcl_name, net, sa, 0,
 					      get_current_cred());
 		/* always save the latest error */
 		if (ret < 0)