From: Arvind Yadav Date: Tue, 1 Aug 2017 15:20:45 +0000 (+0200) Subject: video: fbdev: s3fb: constify pci_device_id. X-Git-Tag: v4.14-rc1~25^2~35 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=916f0ecfe1baa1dddade94f9736d757e3eb00592;p=linux-2.6-block.git video: fbdev: s3fb: constify pci_device_id. pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 20994 2440 8 23442 5b92 drivers/video/fbdev/s3fb.o File size after adding 'const': text data bss dec hex filename 21506 1928 8 23442 5b92 drivers/video/fbdev/s3fb.o Signed-off-by: Arvind Yadav Cc: Paul Mackerras Cc: Benjamin Herrenschmidt Cc: Antonino Daplas Cc: Maik Broemme Cc: Florian Tobias Schandinat Signed-off-by: Bartlomiej Zolnierkiewicz --- diff --git a/drivers/video/fbdev/s3fb.c b/drivers/video/fbdev/s3fb.c index 13b109073c63..d63f23e26f7d 100644 --- a/drivers/video/fbdev/s3fb.c +++ b/drivers/video/fbdev/s3fb.c @@ -1483,7 +1483,7 @@ static int s3_pci_resume(struct pci_dev* dev) /* List of boards that we are trying to support */ -static struct pci_device_id s3_devices[] = { +static const struct pci_device_id s3_devices[] = { {PCI_DEVICE(PCI_VENDOR_ID_S3, 0x8810), .driver_data = CHIP_XXX_TRIO}, {PCI_DEVICE(PCI_VENDOR_ID_S3, 0x8811), .driver_data = CHIP_XXX_TRIO}, {PCI_DEVICE(PCI_VENDOR_ID_S3, 0x8812), .driver_data = CHIP_M65_AURORA64VP},