From: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Date: Wed, 30 Aug 2017 17:36:09 +0000 (-0400)
Subject: staging: unisys: visorbus: visorchipset.c: Fix bug in parser_init_byte_stream.
X-Git-Tag: v4.14-rc1~148^2~47
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=90544cb10caafa6c12315215486a62a8d487f6be;p=linux-2.6-block.git

staging: unisys: visorbus: visorchipset.c: Fix bug in parser_init_byte_stream.

This patch fixes a bug in the function parser_init_byte_stream()
by removing the call to parser_done from goto err_finish_ctx.
The function parser_done() decrements
chipset_dev->controlvm_payload_bytes_buffered which is not
incremented before this gets called.

Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
index 25a30a4b46e4..e296df78c835 100644
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -1505,7 +1505,7 @@ static struct parser_context *parser_init_byte_stream(u64 addr, u32 bytes,
 	return ctx;
 
 err_finish_ctx:
-	parser_done(ctx);
+	kfree(ctx);
 	return NULL;
 }