From: Rob Clark Date: Thu, 19 Jan 2023 23:17:34 +0000 (-0800) Subject: drm/rockchip: Drop unbalanced obj unref X-Git-Tag: v6.4-rc1~31^2~30^2~94 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=8ee3b0e85f6ccd9e6c527bc50eaba774c3bb18d0;p=linux-2.6-block.git drm/rockchip: Drop unbalanced obj unref In the error path, rockchip_drm_gem_object_mmap() is dropping an obj reference that it doesn't own. Fixes: 41315b793e13 ("drm/rockchip: use drm_gem_mmap helpers") Signed-off-by: Rob Clark Signed-off-by: Heiko Stuebner Link: https://patchwork.freedesktop.org/patch/msgid/20230119231734.2884543-1-robdclark@gmail.com --- diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c index c9507d27f0ba..7f5698e3c554 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c @@ -262,9 +262,6 @@ static int rockchip_drm_gem_object_mmap(struct drm_gem_object *obj, else ret = rockchip_drm_gem_object_mmap_dma(obj, vma); - if (ret) - drm_gem_vm_close(vma); - return ret; }