From: Colin Ian King <colin.king@canonical.com>
Date: Tue, 17 Aug 2021 17:08:42 +0000 (+0100)
Subject: bpf: Remove redundant initialization of variable allow
X-Git-Tag: libata-5.15-2021-09-05~51^2~22^2~25
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=8cacfc85b615cc0bae01241593c4b25da6570efc;p=linux-2.6-block.git

bpf: Remove redundant initialization of variable allow

The variable allow is being initialized with a value that is never read, it
is being updated later on. The assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20210817170842.495440-1-colin.king@canonical.com
---

diff --git a/kernel/bpf/cgroup.c b/kernel/bpf/cgroup.c
index a1dedba4c174..9f35928bab0a 100644
--- a/kernel/bpf/cgroup.c
+++ b/kernel/bpf/cgroup.c
@@ -1135,7 +1135,7 @@ int __cgroup_bpf_check_dev_permission(short dev_type, u32 major, u32 minor,
 		.major = major,
 		.minor = minor,
 	};
-	int allow = 1;
+	int allow;
 
 	rcu_read_lock();
 	cgrp = task_dfl_cgroup(current);