From: Changcheng Deng <deng.changcheng@zte.com.cn>
Date: Sat, 28 Aug 2021 01:11:08 +0000 (-0700)
Subject: um: Replace if (cond) BUG() with BUG_ON()
X-Git-Tag: block-5.17-2022-01-21~48^2~27
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=8bd18ef9eaac2e812b42da9eb19b2d59293aa25b;p=linux-block.git

um: Replace if (cond) BUG() with BUG_ON()

Fix the following coccinelle reports:

./arch/um/kernel/mem.c:89:2-5: WARNING: Use BUG_ON instead of if
condition followed by BUG.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
Signed-off-by: Richard Weinberger <richard@nod.at>
---

diff --git a/arch/um/kernel/mem.c b/arch/um/kernel/mem.c
index 0039771eb01c..15295c3237a0 100644
--- a/arch/um/kernel/mem.c
+++ b/arch/um/kernel/mem.c
@@ -85,8 +85,7 @@ static void __init one_md_table_init(pud_t *pud)
 		      __func__, PAGE_SIZE, PAGE_SIZE);
 
 	set_pud(pud, __pud(_KERNPG_TABLE + (unsigned long) __pa(pmd_table)));
-	if (pmd_table != pmd_offset(pud, 0))
-		BUG();
+	BUG_ON(pmd_table != pmd_offset(pud, 0));
 #endif
 }