From: Dan Carpenter Date: Fri, 12 Jan 2024 06:56:25 +0000 (+0300) Subject: platform/x86: silicom-platform: clean up a check X-Git-Tag: v6.9-rc1~117^2~87 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=890a48ca7b05406c538505a92148de7ab0d50591;p=linux-2.6-block.git platform/x86: silicom-platform: clean up a check The error message in this code can't be reached because value is either zero or non-zero. There isn't a third option. Really, it's nicer to write this as a one liner. Signed-off-by: Dan Carpenter Reviewed-by: Ilpo Järvinen Link: https://lore.kernel.org/r/a58bffb7-0a8b-4195-b273-f65a188ace7b@moroto.mountain Signed-off-by: Ilpo Järvinen --- diff --git a/drivers/platform/x86/silicom-platform.c b/drivers/platform/x86/silicom-platform.c index 6ce43ccb3112..c0910af16a3a 100644 --- a/drivers/platform/x86/silicom-platform.c +++ b/drivers/platform/x86/silicom-platform.c @@ -256,12 +256,7 @@ static void silicom_gpio_set(struct gpio_chip *gc, if (direction == GPIO_LINE_DIRECTION_IN) return; - if (value) - silicom_mec_port_set(channel, 0); - else if (value == 0) - silicom_mec_port_set(channel, 1); - else - pr_err("Wrong argument value: %d\n", value); + silicom_mec_port_set(channel, !value); } static int silicom_gpio_direction_output(struct gpio_chip *gc,