From: Oleg Nesterov Date: Tue, 5 Sep 2023 15:46:51 +0000 (+0200) Subject: bpf: task_group_seq_get_next: fix the skip_if_dup_files check X-Git-Tag: io_uring-6.7-2023-11-10~40^2~322^2~13^2~2 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=87abbf7a54f6c9c51374b0701cd7ab47534516ae;p=linux-block.git bpf: task_group_seq_get_next: fix the skip_if_dup_files check Unless I am notally confused it is wrong. We are going to return or skip next_task so we need to check next_task-files, not task->files. Signed-off-by: Oleg Nesterov Acked-by: Yonghong Song Link: https://lore.kernel.org/r/20230905154651.GA24940@redhat.com Signed-off-by: Alexei Starovoitov --- diff --git a/kernel/bpf/task_iter.c b/kernel/bpf/task_iter.c index 1589ec3faded..2264870ae3fc 100644 --- a/kernel/bpf/task_iter.c +++ b/kernel/bpf/task_iter.c @@ -82,7 +82,7 @@ retry: common->pid_visiting = *tid; - if (skip_if_dup_files && task->files == task->group_leader->files) { + if (skip_if_dup_files && next_task->files == next_task->group_leader->files) { task = next_task; goto retry; }