From: Christian Brauner <brauner@kernel.org>
Date: Thu, 12 Jun 2025 13:25:32 +0000 (+0200)
Subject: coredump: directly return
X-Git-Tag: block-6.17-20250808~61^2~1^2~6
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=8434fac512d35597488b13e23cc85e2903f5c8ae;p=linux-block.git

coredump: directly return

instead of jumping to a pointless cleanup label.

Link: https://lore.kernel.org/20250612-work-coredump-massage-v1-18-315c0c34ba94@kernel.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
---

diff --git a/fs/coredump.c b/fs/coredump.c
index 68da77d00170..b2e9ac34d9a3 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -1095,13 +1095,13 @@ void vfs_coredump(const kernel_siginfo_t *siginfo)
 
 	binfmt = mm->binfmt;
 	if (!binfmt || !binfmt->core_dump)
-		goto fail;
+		return;
 	if (!__get_dumpable(cprm.mm_flags))
-		goto fail;
+		return;
 
 	cred = prepare_creds();
 	if (!cred)
-		goto fail;
+		return;
 	/*
 	 * We cannot trust fsuid as being the "true" uid of the process
 	 * nor do we know its entire history. We only know it was tainted
@@ -1194,7 +1194,6 @@ fail_unlock:
 	revert_creds(old_cred);
 fail_creds:
 	put_cred(cred);
-fail:
 	return;
 }