From: Geert Uytterhoeven Date: Wed, 31 Jul 2019 13:29:16 +0000 (+0200) Subject: pinctrl: lantiq: Use kasprintf() instead of fixed buffer formatting X-Git-Tag: for-linus-2019-09-27~67^2~40 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=811604d01e1a98a5cfdebde211f20368d151fcd4;p=linux-2.6-block.git pinctrl: lantiq: Use kasprintf() instead of fixed buffer formatting Improve readability and maintainability by replacing a hardcoded string allocation and formatting by the use of the kasprintf() helper. Signed-off-by: Geert Uytterhoeven Link: https://lore.kernel.org/r/20190731132917.17607-3-geert+renesas@glider.be Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/pinctrl-falcon.c b/drivers/pinctrl/pinctrl-falcon.c index ef133a82e612..4a3b8d2677fd 100644 --- a/drivers/pinctrl/pinctrl-falcon.c +++ b/drivers/pinctrl/pinctrl-falcon.c @@ -96,12 +96,8 @@ static void lantiq_load_pin_desc(struct pinctrl_pin_desc *d, int bank, int len) int i; for (i = 0; i < len; i++) { - /* strlen("ioXYZ") + 1 = 6 */ - char *name = kzalloc(6, GFP_KERNEL); - - snprintf(name, 6, "io%d", base + i); d[i].number = base + i; - d[i].name = name; + d[i].name = kasprintf(GFP_KERNEL, "io%d", base + i); } pad_count[bank] = len; }