From: Colin Ian King Date: Mon, 4 Jun 2018 11:49:19 +0000 (+0100) Subject: ALSA: usb-audio: remove redundant check on err X-Git-Tag: for-linus-20180616~69^2~1 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=7a6fc28b162bc0e48d8cef72be8226e11300317b;p=linux-block.git ALSA: usb-audio: remove redundant check on err The check on err is redundant as both the true and false paths end up on a break statement. Remove the redundant check. Detected by CoverityScan, CID#1268773 ("Identical code for different branches") Signed-off-by: Colin Ian King Signed-off-by: Takashi Iwai --- diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c index 4149543f613e..e82a72fea9a1 100644 --- a/sound/usb/mixer_quirks.c +++ b/sound/usb/mixer_quirks.c @@ -1849,8 +1849,6 @@ int snd_usb_mixer_apply_create_quirk(struct usb_mixer_interface *mixer) /* EMU0204 */ case USB_ID(0x041e, 0x3f19): err = snd_emu0204_controls_create(mixer); - if (err < 0) - break; break; case USB_ID(0x0763, 0x2030): /* M-Audio Fast Track C400 */