From: Pavel Begunkov <asml.silence@gmail.com>
Date: Thu, 1 Apr 2021 14:43:51 +0000 (+0100)
Subject: io_uring: better ref handling in poll_remove_one
X-Git-Tag: for-5.13/io_uring-2021-04-27~86
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=7394161cb8bd26be43ebf0075e3b0197a6c3ca01;p=linux-block.git

io_uring: better ref handling in poll_remove_one

Instead of io_put_req() to drop not a final ref, use req_ref_put(),
which is slimmer and will also check the invariant.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/85b5774ce13ae55cc2e705abdc8cbafe1212f1bd.1617287883.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---

diff --git a/fs/io_uring.c b/fs/io_uring.c
index edb5b9d0fd1a..e92de7e206c0 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -5244,7 +5244,7 @@ static bool io_poll_remove_waitqs(struct io_kiocb *req)
 		/* non-poll requests have submit ref still */
 		do_complete = __io_poll_remove_one(req, &apoll->poll, true);
 		if (do_complete) {
-			io_put_req(req);
+			req_ref_put(req);
 			kfree(apoll->double_poll);
 			kfree(apoll);
 		}