From: Xi Pardee Date: Fri, 25 Apr 2025 19:52:31 +0000 (-0700) Subject: platform/x86:intel/pmc: Use devm for mutex_init X-Git-Tag: v6.16-rc1~125^2~46 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=6f130e048d390f1f63e05d899690bf2115175a17;p=linux-2.6-block.git platform/x86:intel/pmc: Use devm for mutex_init Use devm_mutex_init() to avoid accidental resource leak in the future. Signed-off-by: Xi Pardee Link: https://lore.kernel.org/r/20250425195237.493129-4-xi.pardee@linux.intel.com Reviewed-by: Ilpo Järvinen Signed-off-by: Ilpo Järvinen --- diff --git a/drivers/platform/x86/intel/pmc/core.c b/drivers/platform/x86/intel/pmc/core.c index 2028a769cddb..db3fccca06fb 100644 --- a/drivers/platform/x86/intel/pmc/core.c +++ b/drivers/platform/x86/intel/pmc/core.c @@ -1681,7 +1681,6 @@ static void pmc_core_clean_structure(struct platform_device *pdev) pmt_telem_unregister_endpoint(pmcdev->punit_ep); platform_set_drvdata(pdev, NULL); - mutex_destroy(&pmcdev->lock); } static int pmc_core_probe(struct platform_device *pdev) @@ -1726,7 +1725,9 @@ static int pmc_core_probe(struct platform_device *pdev) if (!pmcdev->pkgc_res_cnt) return -ENOMEM; - mutex_init(&pmcdev->lock); + ret = devm_mutex_init(&pdev->dev, &pmcdev->lock); + if (ret) + return ret; if (pmc_dev_info->init) ret = pmc_dev_info->init(pmcdev, pmc_dev_info);