From: Jens Axboe <jens.axboe@oracle.com>
Date: Sat, 10 Feb 2007 23:57:13 +0000 (+0100)
Subject: [PATCH] Allow thread/group dump regardless of error state
X-Git-Tag: fio-1.12~104
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=6d663077379b40e1ec6e2321fe8a731087777d32;p=fio.git

[PATCH] Allow thread/group dump regardless of error state

Just because the thread ended in error, doesn't mean the
stats aren't interesting. So dump everything and make sure
the error and verror are visible.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
---

diff --git a/stat.c b/stat.c
index fb776e9c..9810e419 100644
--- a/stat.c
+++ b/stat.c
@@ -441,10 +441,13 @@ static void show_thread_status(struct thread_data *td,
 	double io_u_dist[FIO_IO_U_MAP_NR];
 	int i;
 
-	if (!(td->io_bytes[0] + td->io_bytes[1]) && !td->error)
+	if (!(td->io_bytes[0] + td->io_bytes[1]))
 		return;
 
-	fprintf(f_out, "%s: (groupid=%d): err=%2d: pid=%d\n",td->name, td->groupid, td->error, td->pid);
+	if (!td->error)
+		fprintf(f_out, "%s: (groupid=%d): err=%2d: pid=%d\n",td->name, td->groupid, td->error, td->pid);
+	else
+		fprintf(f_out, "%s: (groupid=%d): err=%2d (%s): pid=%d\n",td->name, td->groupid, td->error, td->verror, td->pid);
 
 	show_ddir_status(td, rs, td->ddir);
 	if (td->io_bytes[td->ddir ^ 1])
@@ -553,11 +556,6 @@ void show_run_stats(void)
 	for_each_td(td, i) {
 		unsigned long long rbw, wbw;
 
-		if (td->error) {
-			fprintf(f_out, "%s: %s\n", td->name, td->verror);
-			continue;
-		}
-
 		rs = &runstats[td->groupid];
 
 		if (td->runtime[0] < rs->min_run[0] || !rs->min_run[0])