From: Alexander Mikhalitsyn Date: Tue, 3 Sep 2024 15:16:24 +0000 (+0200) Subject: fuse: warn if fuse_access is called when idmapped mounts are allowed X-Git-Tag: v6.12-rc1~57^2~9 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=6d14b18596ca69719cfe1af87dbf3c5e763d29b5;p=linux-block.git fuse: warn if fuse_access is called when idmapped mounts are allowed It is not possible with the current fuse code, but let's protect ourselves from regressions in the future. Signed-off-by: Alexander Mikhalitsyn Signed-off-by: Miklos Szeredi --- diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c index 6f289fa9cc62..99f9948bf68b 100644 --- a/fs/fuse/dir.c +++ b/fs/fuse/dir.c @@ -1474,6 +1474,14 @@ static int fuse_access(struct inode *inode, int mask) BUG_ON(mask & MAY_NOT_BLOCK); + /* + * We should not send FUSE_ACCESS to the userspace + * when idmapped mounts are enabled as for this case + * we have fc->default_permissions = 1 and access + * permission checks are done on the kernel side. + */ + WARN_ON_ONCE(!(fm->sb->s_iflags & SB_I_NOIDMAP)); + if (fm->fc->no_access) return 0;