From: Sitsofe Wheeler <sitsofe@yahoo.com>
Date: Mon, 21 Aug 2017 21:15:00 +0000 (+0100)
Subject: filesetup: add direct=1 failure warning to layout
X-Git-Tag: fio-3.1~38^2
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=6c3169f9cbe179a89bbbaa9de26e54711d027e99;p=fio.git

filesetup: add direct=1 failure warning to layout

Add warning about the filesystem not liking direct=1/buffered=0 to
initial layout code.

v2:
- Update warning to include /buffered=0 so it matches other EINVAL
  warnings
- Minor commit message update

Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
---

diff --git a/filesetup.c b/filesetup.c
index b9d68c45..a6a94ee1 100644
--- a/filesetup.c
+++ b/filesetup.c
@@ -162,8 +162,14 @@ static int extend_file(struct thread_data *td, struct fio_file *f)
 		if (err == ENOENT && !td->o.allow_create)
 			log_err("fio: file creation disallowed by "
 					"allow_file_create=0\n");
-		else
+		else {
+			if (err == EINVAL && (flags & OS_O_DIRECT))
+				log_err("fio: looks like your filesystem "
+					"does not support "
+					"direct=1/buffered=0\n");
+
 			td_verror(td, err, "open");
+		}
 		return 1;
 	}