From: Andy Shevchenko Date: Thu, 13 Mar 2025 09:15:53 +0000 (+0200) Subject: mtd: mtdpart: Do not supply NULL to printf() X-Git-Tag: io_uring-6.15-20250403~92^2~5 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=6bc9f42739889eaaaa47b90f48e4ef8323efa3ea;p=linux-block.git mtd: mtdpart: Do not supply NULL to printf() GCC compiler is not happy about NULL being supplied as printf() parameter: drivers/mtd/mtdpart.c:693:34: error: ‘%s’ directive argument is null [-Werror=format-overflow=] Move the code after the parser test for NULL, and drop the ternary completely. The user can deduct this since when it's not NULL two messages will be printed. Signed-off-by: Andy Shevchenko Reviewed-by: Zhihao Cheng Signed-off-by: Miquel Raynal --- diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c index 6811a714349d..994e8c51e674 100644 --- a/drivers/mtd/mtdpart.c +++ b/drivers/mtd/mtdpart.c @@ -690,10 +690,9 @@ int parse_mtd_partitions(struct mtd_info *master, const char *const *types, parser = mtd_part_parser_get(*types); if (!parser && !request_module("%s", *types)) parser = mtd_part_parser_get(*types); - pr_debug("%s: got parser %s\n", master->name, - parser ? parser->name : NULL); if (!parser) continue; + pr_debug("%s: got parser %s\n", master->name, parser->name); ret = mtd_part_do_parse(parser, master, &pparts, data); if (ret <= 0) mtd_part_parser_put(parser);