From: Eric W. Biederman Date: Wed, 20 Oct 2021 17:43:47 +0000 (-0500) Subject: exit/doublefault: Remove apparently bogus comment about rewind_stack_do_exit X-Git-Tag: v5.16-rc1~30^2~23 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=6ab80d88f82e84e331e79ca4b7e2ca2fe63c8c2f;p=linux-2.6-block.git exit/doublefault: Remove apparently bogus comment about rewind_stack_do_exit I do not see panic calling rewind_stack_do_exit anywhere, nor can I find anywhere in the history where doublefault_shim has called rewind_stack_do_exit. So I don't think this comment was ever actually correct. Cc: Andy Lutomirski Fixes: 7d8d8cfdee9a ("x86/doublefault/32: Rewrite the x86_32 #DF handler and unify with 64-bit") Link: https://lkml.kernel.org/r/20211020174406.17889-1-ebiederm@xmission.com Signed-off-by: Eric W. Biederman --- diff --git a/arch/x86/kernel/doublefault_32.c b/arch/x86/kernel/doublefault_32.c index d1d49e3d536b..3b58d8703094 100644 --- a/arch/x86/kernel/doublefault_32.c +++ b/arch/x86/kernel/doublefault_32.c @@ -77,9 +77,6 @@ asmlinkage noinstr void __noreturn doublefault_shim(void) * some way to reconstruct CR3. We could make a credible guess based * on cpu_tlbstate, but that would be racy and would not account for * PTI. - * - * Instead, don't bother. We can return through - * rewind_stack_do_exit() instead. */ panic("cannot return from double fault\n"); }