From: Chao Yu Date: Sun, 29 Jul 2018 04:16:59 +0000 (+0800) Subject: f2fs: fix to clear PG_checked flag in set_page_dirty() X-Git-Tag: for-linus-20180825~6^2~23 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=66110abc4c931f879d70e83e1281f891699364bf;p=linux-block.git f2fs: fix to clear PG_checked flag in set_page_dirty() PG_checked flag will be set on data page during GC, later, we can recognize such page by the flag and migrate page to cold segment. But previously, we don't clear this flag when invalidating data page, after page redirtying, we will write it into wrong log. Let's clear PG_checked flag in set_page_dirty() to avoid this. Signed-off-by: Weichao Guo Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim --- diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 5d152de30449..b7986b2e5d1d 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -2542,6 +2542,10 @@ static int f2fs_set_data_page_dirty(struct page *page) if (!PageUptodate(page)) SetPageUptodate(page); + /* don't remain PG_checked flag which was set during GC */ + if (is_cold_data(page)) + clear_cold_data(page); + if (f2fs_is_atomic_file(inode) && !f2fs_is_commit_atomic_write(inode)) { if (!IS_ATOMIC_WRITTEN_PAGE(page)) { f2fs_register_inmem_page(inode, page);