From: Jens Axboe <axboe@suse.de>
Date: Fri, 7 Oct 2005 09:12:58 +0000 (+0200)
Subject: [PATCH] blkparse_fmt: use memcmp() it is (usually) faster
X-Git-Tag: blktrace-0.99~24
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=63756b50407dc9a5976210320dccbf6dc57cbaff;p=blktrace.git

[PATCH] blkparse_fmt: use memcmp() it is (usually) faster

At least it has better worst case performance.
---

diff --git a/blkparse_fmt.c b/blkparse_fmt.c
index 8031a8e..34b920b 100644
--- a/blkparse_fmt.c
+++ b/blkparse_fmt.c
@@ -79,14 +79,11 @@ static inline void fill_rwbs(char *rwbs, struct blk_io_trace *t)
 	rwbs[i] = '\0';
 }
 
-static int pdu_rest_is_zero(unsigned char *pdu, int len)
+static inline int pdu_rest_is_zero(unsigned char *pdu, int len)
 {
-	int i = 0;
-
-	while (!pdu[i] && i < len)
-		i++;
+	static char zero[4096];
 
-	return i == len;
+	return !memcmp(pdu, zero, len);
 }
 
 static char *dump_pdu(unsigned char *pdu_buf, int pdu_len)