From: Arvind Yadav Date: Thu, 16 Nov 2017 04:37:51 +0000 (-0500) Subject: media: winbond-cir: Fix pnp_irq's error checking for wbcir_probe X-Git-Tag: for-linus-20180210^2~11^2~228 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=621fa19a2485ca6f4612b3c044766bc173551d76;p=linux-2.6-block.git media: winbond-cir: Fix pnp_irq's error checking for wbcir_probe The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/rc/winbond-cir.c b/drivers/media/rc/winbond-cir.c index 3ca7ab48293d..0adf0991f5ab 100644 --- a/drivers/media/rc/winbond-cir.c +++ b/drivers/media/rc/winbond-cir.c @@ -1044,7 +1044,7 @@ wbcir_probe(struct pnp_dev *device, const struct pnp_device_id *dev_id) data->irq = pnp_irq(device, 0); if (data->wbase == 0 || data->ebase == 0 || - data->sbase == 0 || data->irq == 0) { + data->sbase == 0 || data->irq == -1) { err = -ENODEV; dev_err(dev, "Invalid resources\n"); goto exit_free_data;