From: Ilya Dryomov <idryomov@gmail.com>
Date: Thu, 11 Oct 2018 14:15:38 +0000 (+0200)
Subject: ceph: num_ops is off by one in ceph_aio_retry_work()
X-Git-Tag: v4.20-rc1~46^2~10
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=61d2f855042cfcce9b78fa10fe7cd2020598263b;p=linux-block.git

ceph: num_ops is off by one in ceph_aio_retry_work()

Two OSD op slots are allocated, but only one is ever used.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
---

diff --git a/fs/ceph/file.c b/fs/ceph/file.c
index 213e7d98248a..0265f9ae0ab9 100644
--- a/fs/ceph/file.c
+++ b/fs/ceph/file.c
@@ -858,7 +858,7 @@ static void ceph_aio_retry_work(struct work_struct *work)
 	}
 	spin_unlock(&ci->i_ceph_lock);
 
-	req = ceph_osdc_alloc_request(orig_req->r_osdc, snapc, 2,
+	req = ceph_osdc_alloc_request(orig_req->r_osdc, snapc, 1,
 			false, GFP_NOFS);
 	if (!req) {
 		ret = -ENOMEM;