From: Manikanta Guntupalli Date: Thu, 6 Feb 2025 11:57:08 +0000 (+0530) Subject: i2c: cadence: Move reset_control_assert after pm_runtime_set_suspended in probe error... X-Git-Tag: v6.15-rc1~74^2~1^2~16 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=61b804548e17447b2a777650a8ff0708707f0cb9;p=linux-2.6-block.git i2c: cadence: Move reset_control_assert after pm_runtime_set_suspended in probe error path Ensure reset_control_assert() is called after pm_runtime_set_suspended() in the cdns_i2c_probe exit path to maintain proper power management sequence in error cases. Signed-off-by: Manikanta Guntupalli Signed-off-by: Andi Shyti Link: https://lore.kernel.org/r/20250206115708.1085523-3-manikanta.guntupalli@amd.com --- diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c index 51dc7728d133..8df63aaf2a80 100644 --- a/drivers/i2c/busses/i2c-cadence.c +++ b/drivers/i2c/busses/i2c-cadence.c @@ -1609,9 +1609,9 @@ static int cdns_i2c_probe(struct platform_device *pdev) err_clk_notifier_unregister: clk_notifier_unregister(id->clk, &id->clk_rate_change_nb); - reset_control_assert(id->reset); pm_runtime_disable(&pdev->dev); pm_runtime_set_suspended(&pdev->dev); + reset_control_assert(id->reset); return ret; }