From: Wei Chen <harperchen1110@gmail.com>
Date: Wed, 15 Mar 2023 09:05:18 +0000 (+0000)
Subject: fbdev: lxfb: Fix potential divide by zero
X-Git-Tag: v6.3-rc3~8^2~2
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=61ac4b86a4c047c20d5cb423ddd87496f14d9868;p=linux-2.6-block.git

fbdev: lxfb: Fix potential divide by zero

var->pixclock can be assigned to zero by user. Without proper
check, divide by zero would occur in lx_set_clock.

Error out if var->pixclock is zero.

Signed-off-by: Wei Chen <harperchen1110@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
---

diff --git a/drivers/video/fbdev/geode/lxfb_core.c b/drivers/video/fbdev/geode/lxfb_core.c
index 8130e9eee2b4..556d8b1a9e06 100644
--- a/drivers/video/fbdev/geode/lxfb_core.c
+++ b/drivers/video/fbdev/geode/lxfb_core.c
@@ -235,6 +235,9 @@ static void get_modedb(struct fb_videomode **modedb, unsigned int *size)
 
 static int lxfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
 {
+	if (!var->pixclock)
+		return -EINVAL;
+
 	if (var->xres > 1920 || var->yres > 1440)
 		return -EINVAL;