From: Kangjie Lu <kjlu@umn.edu>
Date: Mon, 25 Mar 2019 20:23:08 +0000 (-0500)
Subject: thunderbolt: property: Fix a missing check of kzalloc
X-Git-Tag: for-linus-20190516~74^2~60^2~38
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=6183d5a51866f3acdeeb66b75e87d44025b01a55;p=linux-2.6-block.git

thunderbolt: property: Fix a missing check of kzalloc

No check is enforced for the return value of kzalloc,
which may lead to NULL-pointer dereference.

The patch fixes this issue.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---

diff --git a/drivers/thunderbolt/property.c b/drivers/thunderbolt/property.c
index 841314deb446..d5b0cdb8f0b1 100644
--- a/drivers/thunderbolt/property.c
+++ b/drivers/thunderbolt/property.c
@@ -587,7 +587,12 @@ int tb_property_add_text(struct tb_property_dir *parent, const char *key,
 		return -ENOMEM;
 
 	property->length = size / 4;
-	property->value.data = kzalloc(size, GFP_KERNEL);
+	property->value.text = kzalloc(size, GFP_KERNEL);
+	if (!property->value.text) {
+		kfree(property);
+		return -ENOMEM;
+	}
+
 	strcpy(property->value.text, text);
 
 	list_add_tail(&property->list, &parent->properties);