From: Joao Martins Date: Sat, 7 Sep 2019 23:45:23 +0000 (+0100) Subject: cpuidle-haltpoll: return -ENODEV on modinit failure X-Git-Tag: for-linus-2019-09-27~102^2~3^2~2 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=5cc59f597c0666c6a7e1c67aac9063895949fd56;p=linux-block.git cpuidle-haltpoll: return -ENODEV on modinit failure When a user loads cpuidle-haltpoll on a non KVM guest the module will successfully load, even though idle driver registration didn't take place. We should instead return -ENODEV signaling the user that the driver can't be loaded, like other error paths in haltpoll_init(). An example of such error paths is when we return -EBUSY when attempting to register an idle driver when it had one already (e.g. intel_idle loads at boot and then we attempt to insert module cpuidle-haltpoll). Fixes: fa86ee90eb11 ("add cpuidle-haltpoll driver") Signed-off-by: Joao Martins Signed-off-by: Rafael J. Wysocki --- diff --git a/drivers/cpuidle/cpuidle-haltpoll.c b/drivers/cpuidle/cpuidle-haltpoll.c index 519e90d125cf..7a0239ef717e 100644 --- a/drivers/cpuidle/cpuidle-haltpoll.c +++ b/drivers/cpuidle/cpuidle-haltpoll.c @@ -99,7 +99,7 @@ static int __init haltpoll_init(void) cpuidle_poll_state_init(drv); if (!kvm_para_available()) - return 0; + return -ENODEV; ret = cpuidle_register_driver(drv); if (ret < 0)