From: Nathan Chancellor <nathan@kernel.org>
Date: Mon, 16 Aug 2021 20:20:55 +0000 (-0700)
Subject: kbuild: Add a comment above -Wno-gnu
X-Git-Tag: misc-5.15-2021-09-05~2^2~20
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=5c6ae0efca8d7aeac02f8734825067cd9475a264;p=linux-block.git

kbuild: Add a comment above -Wno-gnu

Whenever a warning is disabled, it is helpful for future travelers to
understand why the warning is disabled and why it is acceptable to do
so. Add a comment for -Wno-gnu so that people understand why it is
disabled.

Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

diff --git a/Makefile b/Makefile
index add32a749860..8dc6707542a8 100644
--- a/Makefile
+++ b/Makefile
@@ -782,6 +782,7 @@ KBUILD_CFLAGS += $(stackp-flags-y)
 
 ifdef CONFIG_CC_IS_CLANG
 KBUILD_CPPFLAGS += -Qunused-arguments
+# The kernel builds with '-std=gnu89' so use of GNU extensions is acceptable.
 KBUILD_CFLAGS += -Wno-gnu
 # CLANG uses a _MergedGlobals as optimization, but this breaks modpost, as the
 # source of a reference will be _MergedGlobals and not on of the whitelisted names.