From: Todd Poynor Date: Sat, 28 Jul 2018 19:33:24 +0000 (-0700) Subject: staging: gasket: core: hold reference on device while in use X-Git-Tag: for-linus-20180825~50^2~260 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=5b6e80cc9806a5cf78f68df2b6b64812b51d91c9;p=linux-2.6-block.git staging: gasket: core: hold reference on device while in use Hold a reference on the struct device while a pointer to that device is in use by gasket. Reported-by: Greg Kroah-Hartman Signed-off-by: Todd Poynor Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c index 859a6df9e12d..2b484d067c38 100644 --- a/drivers/staging/gasket/gasket_core.c +++ b/drivers/staging/gasket/gasket_core.c @@ -448,7 +448,7 @@ static int gasket_alloc_dev( gasket_dev->internal_desc = internal_desc; gasket_dev->dev_idx = dev_idx; snprintf(gasket_dev->kobj_name, GASKET_NAME_MAX, "%s", kobj_name); - gasket_dev->dev = parent; + gasket_dev->dev = get_device(parent); /* gasket_bar_data is uninitialized. */ gasket_dev->num_page_tables = driver_desc->num_page_tables; /* max_page_table_size and *page table are uninit'ed */ @@ -487,7 +487,7 @@ static void gasket_free_dev(struct gasket_dev *gasket_dev) mutex_lock(&internal_desc->mutex); internal_desc->devs[gasket_dev->dev_idx] = NULL; mutex_unlock(&internal_desc->mutex); - + put_device(gasket_dev->dev); kfree(gasket_dev); }