From: Aleksandr Loktionov Date: Thu, 28 Feb 2019 17:52:49 +0000 (-0800) Subject: i40e: remove error msg when vf with port vlan tries to remove vlan 0 X-Git-Tag: for-linus-20190516~56^2~57^2~8 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=5a189f15502f92abf8949a0898816a2abadd5df6;p=linux-block.git i40e: remove error msg when vf with port vlan tries to remove vlan 0 VF's attempt to delete vlan 0 when a port vlan is configured is harmless in this case pf driver just does nothing. If vf will try to remove other vlans when a port vlan is configured it will still produce error as before. Signed-off-by: Aleksandr Loktionov Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c index 71cd159e7902..24628de8e624 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c +++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c @@ -2766,7 +2766,8 @@ static int i40e_vc_remove_vlan_msg(struct i40e_vf *vf, u8 *msg) vsi = pf->vsi[vf->lan_vsi_idx]; if (vsi->info.pvid) { - aq_ret = I40E_ERR_PARAM; + if (vfl->num_elements > 1 || vfl->vlan_id[0]) + aq_ret = I40E_ERR_PARAM; goto error_param; }