From: Yang Yingliang <yangyingliang@huawei.com>
Date: Wed, 11 May 2022 06:46:22 +0000 (+0800)
Subject: edd: simplify the check of 'attr->test' in edd_populate_dir()
X-Git-Tag: v5.19-rc1~45^2~62
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=5621a0bcb4b4dffc87d74330a9a31b868572f763;p=linux-block.git

edd: simplify the check of 'attr->test' in edd_populate_dir()

attr->test check is not needed when !attr->test is false.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220511064622.3399164-1-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c
index 69353dd0ea22..5cc238916551 100644
--- a/drivers/firmware/edd.c
+++ b/drivers/firmware/edd.c
@@ -685,8 +685,7 @@ static void edd_populate_dir(struct edd_device * edev)
 	int i;
 
 	for (i = 0; (attr = edd_attrs[i]) && !error; i++) {
-		if (!attr->test ||
-		    (attr->test && attr->test(edev)))
+		if (!attr->test || attr->test(edev))
 			error = sysfs_create_file(&edev->kobj,&attr->attr);
 	}