From: Jakub Kicinski <kuba@kernel.org>
Date: Wed, 13 Oct 2021 20:44:30 +0000 (-0700)
Subject: ethernet: make eth_hw_addr_random() use dev_addr_set()
X-Git-Tag: block-5.16-2021-11-13~96^2~204^2~5
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=54f2d8d6ca99a3e24efc9c8b055bbcbe0b583227;p=linux-block.git

ethernet: make eth_hw_addr_random() use dev_addr_set()

Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
of VLANs...") introduced a rbtree for faster Ethernet address look
up. To maintain netdev->dev_addr in this tree we need to make all
the writes to it got through appropriate helpers.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---

diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h
index 3cf546d2ffd1..76f7ff684cbf 100644
--- a/include/linux/etherdevice.h
+++ b/include/linux/etherdevice.h
@@ -269,8 +269,11 @@ static inline void eth_zero_addr(u8 *addr)
  */
 static inline void eth_hw_addr_random(struct net_device *dev)
 {
+	u8 addr[ETH_ALEN];
+
+	eth_random_addr(addr);
+	__dev_addr_set(dev, addr, ETH_ALEN);
 	dev->addr_assign_type = NET_ADDR_RANDOM;
-	eth_random_addr(dev->dev_addr);
 }
 
 /**