From: Johan Hovold Date: Thu, 21 Jan 2021 10:29:14 +0000 (+0100) Subject: USB: serial: xr: fix interface leak at disconnect X-Git-Tag: io_uring-worker.v3-2021-02-25~75^2~10^2~22 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=54c98d9d7ba48c66d64f72e3d5a7586601705611;p=linux-block.git USB: serial: xr: fix interface leak at disconnect Make sure to release the control interface at disconnect so that the driver can be unbound without leaking resources (and later rebound). Fixes: c2d405aa86b4 ("USB: serial: add MaxLinear/Exar USB to Serial driver") Signed-off-by: Johan Hovold --- diff --git a/drivers/usb/serial/xr_serial.c b/drivers/usb/serial/xr_serial.c index 7be6da6a5cf3..5e110b0c8e71 100644 --- a/drivers/usb/serial/xr_serial.c +++ b/drivers/usb/serial/xr_serial.c @@ -564,6 +564,15 @@ static int xr_probe(struct usb_serial *serial, const struct usb_device_id *id) return 0; } +static void xr_disconnect(struct usb_serial *serial) +{ + struct usb_driver *driver = serial->type->usb_driver; + struct usb_interface *control_interface; + + control_interface = usb_ifnum_to_if(serial->dev, 0); + usb_driver_release_interface(driver, control_interface); +} + static const struct usb_device_id id_table[] = { { USB_DEVICE(0x04e2, 0x1410) }, /* XR21V141X */ { } @@ -578,6 +587,7 @@ static struct usb_serial_driver xr_device = { .id_table = id_table, .num_ports = 1, .probe = xr_probe, + .disconnect = xr_disconnect, .open = xr_open, .close = xr_close, .break_ctl = xr_break_ctl,