From: Colin Ian King <colin.i.king@gmail.com>
Date: Wed, 19 Mar 2025 11:30:10 +0000 (+0000)
Subject: f2fs: remove redundant assignment to variable err
X-Git-Tag: v6.16-rc1~115^2~194
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=539d33455f96532ac88115c35b1769db966003c6;p=linux-block.git

f2fs: remove redundant assignment to variable err

The variable err is being assigned a value zero and then the following
goto page_hit reassigns err a new value. The zero assignment is redundant
and can be removed.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
[Jaegeuk Kim: clean up braces and if condition, suggested by Dan Carpenter]
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---

diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 5f15c224bf78..3f6f5e54759c 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1494,12 +1494,10 @@ repeat:
 		return folio;
 
 	err = read_node_page(&folio->page, 0);
-	if (err < 0) {
+	if (err < 0)
 		goto out_put_err;
-	} else if (err == LOCKED_PAGE) {
-		err = 0;
+	if (err == LOCKED_PAGE)
 		goto page_hit;
-	}
 
 	if (parent)
 		f2fs_ra_node_pages(parent, start + 1, MAX_RA_NODE);