From: Anson Huang <Anson.Huang@nxp.com>
Date: Fri, 21 Feb 2020 06:31:56 +0000 (+0800)
Subject: clk: imx: pll14xx: Return error if pll type is invalid
X-Git-Tag: libata-5.7-2020-04-09~27^2^5~2^2~11
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=530cf8d49f2a650625eee6ce28793bd7974e14bd;p=linux-block.git

clk: imx: pll14xx: Return error if pll type is invalid

When pll type is invalid, ONLY output error message is NOT enough,
should return error immediately.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
---

diff --git a/drivers/clk/imx/clk-pll14xx.c b/drivers/clk/imx/clk-pll14xx.c
index 37e311e1d058..a83bbbee77d9 100644
--- a/drivers/clk/imx/clk-pll14xx.c
+++ b/drivers/clk/imx/clk-pll14xx.c
@@ -410,6 +410,8 @@ struct clk_hw *imx_clk_hw_pll14xx(const char *name, const char *parent_name,
 	default:
 		pr_err("%s: Unknown pll type for pll clk %s\n",
 		       __func__, name);
+		kfree(pll);
+		return ERR_PTR(-EINVAL);
 	};
 
 	pll->base = base;