From: Luis Chamberlain Date: Mon, 27 Sep 2021 22:01:07 +0000 (-0700) Subject: pcd: add error handling support for add_disk() X-Git-Tag: for-5.16/drivers-2021-10-29~81 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=4dfbd1390af60765774d9565858d1a6fadacde32;p=linux-block.git pcd: add error handling support for add_disk() We never checked for errors on add_disk() as this function returned void. Now that this is fixed, use the shiny new error handling. Signed-off-by: Luis Chamberlain Signed-off-by: Jens Axboe --- diff --git a/drivers/block/paride/pcd.c b/drivers/block/paride/pcd.c index 93ed63626232..a7fab3830d7b 100644 --- a/drivers/block/paride/pcd.c +++ b/drivers/block/paride/pcd.c @@ -941,9 +941,13 @@ static int pcd_init_unit(struct pcd_unit *cd, bool autoprobe, int port, cd->present = 1; pcd_probe_capabilities(cd); register_cdrom(cd->disk, &cd->info); - add_disk(cd->disk); + ret = add_disk(cd->disk); + if (ret) + goto out_unreg_cdrom; return 0; +out_unreg_cdrom: + unregister_cdrom(&cd->info); out_pi_release: pi_release(cd->pi); out_free_disk: