From: Colin Ian King <colin.king@canonical.com>
Date: Mon, 2 Sep 2019 18:43:34 +0000 (+0100)
Subject: usb: cdns3: remove redundant assignment to ret on error exit path
X-Git-Tag: for-linus-2019-09-27~96^2~33
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=4d2233ecec8e5e2ac3e2efd5bf8fdfaf1dab30d9;p=linux-block.git

usb: cdns3: remove redundant assignment to ret on error exit path

In the case where an allocation fails for priv_ep ret is
assigned -ENOMEM and the code exits via the exit path 'err'.
The exit path returns -ENOMEM without using variable ret, so
the assingment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20190902184334.27406-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
index ddac638f0409..9536908aabb4 100644
--- a/drivers/usb/cdns3/gadget.c
+++ b/drivers/usb/cdns3/gadget.c
@@ -2445,10 +2445,8 @@ static int cdns3_init_eps(struct cdns3_device *priv_dev)
 
 		priv_ep = devm_kzalloc(priv_dev->dev, sizeof(*priv_ep),
 				       GFP_KERNEL);
-		if (!priv_ep) {
-			ret = -ENOMEM;
+		if (!priv_ep)
 			goto err;
-		}
 
 		/* set parent of endpoint object */
 		priv_ep->cdns3_dev = priv_dev;