From: Dan Carpenter Date: Thu, 15 Sep 2022 14:13:34 +0000 (+0300) Subject: wifi: rtw89: uninitialized variable on error in rtw89_early_fw_feature_recognize() X-Git-Tag: block-6.1-2022-13-10~73^2~30^2~59 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=4c3140f4cea66b06e4a982e0c2f7b7d113040b26;p=linux-block.git wifi: rtw89: uninitialized variable on error in rtw89_early_fw_feature_recognize() If request_partial_firmware_into_buf() fails then "firmware" is not initialized and the release_firmware(firmware) will crash. Fixes: deebea35d699 ("wifi: rtw89: early recognize FW feature to decide if chanctx") Signed-off-by: Dan Carpenter Acked-by: Ping-Ke Shih Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/YyMzDtX/3fUBnonC@kili --- diff --git a/drivers/net/wireless/realtek/rtw89/fw.c b/drivers/net/wireless/realtek/rtw89/fw.c index 04fee40b062a..5e65f2c410bf 100644 --- a/drivers/net/wireless/realtek/rtw89/fw.c +++ b/drivers/net/wireless/realtek/rtw89/fw.c @@ -271,7 +271,7 @@ void rtw89_early_fw_feature_recognize(struct device *device, device, &buf, sizeof(buf), 0); if (ret) { dev_err(device, "failed to early request firmware: %d\n", ret); - goto out; + return; } ver_code = buf.mfw_hdr.sig != RTW89_MFW_SIG ?