From: Russell King (Oracle) Date: Sat, 12 Apr 2025 14:09:59 +0000 (+0100) Subject: net: stmmac: qcom-ethqos: remove unnecessary setting max_speed X-Git-Tag: v6.16-rc1~132^2~307^2~1 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=4c30093f784e6b098da34165408b00c1810ef9ab;p=linux-block.git net: stmmac: qcom-ethqos: remove unnecessary setting max_speed Phylink will already limit the MAC speed according to the interface, so if 2500BASE-X is selected, the maximum speed will be 2.5G. It is, therefore, not necessary to set a speed limit. Remove setting plat_dat->max_speed from this glue driver. Signed-off-by: Russell King (Oracle) Reviewed-by: Andrew Lunn Link: https://patch.msgid.link/E1u3bYV-000EcQ-Cv@rmk-PC.armlinux.org.uk Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index cd25aea3e48f..e8d4925be21c 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -676,7 +676,6 @@ static void qcom_ethqos_speed_mode_2500(struct net_device *ndev, void *data) { struct stmmac_priv *priv = netdev_priv(ndev); - priv->plat->max_speed = 2500; priv->plat->phy_interface = PHY_INTERFACE_MODE_2500BASEX; }