From: Ai Chao Date: Thu, 14 Mar 2024 05:28:28 +0000 (+0800) Subject: platform/chrome: wilco_ec: use sysfs_emit() instead of sprintf() X-Git-Tag: block-6.10-20240523~19^2~21 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=48e49af7108b6e0d014a08650c41470f812e44bc;p=linux-block.git platform/chrome: wilco_ec: use sysfs_emit() instead of sprintf() Follow the advice in Documentation/filesystems/sysfs.rst: show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: Ai Chao Link: https://lore.kernel.org/r/20240314052828.186924-1-aichao@kylinos.cn Signed-off-by: Tzung-Bi Shih --- diff --git a/drivers/platform/chrome/wilco_ec/sysfs.c b/drivers/platform/chrome/wilco_ec/sysfs.c index 893c59dde32a..d44c43559621 100644 --- a/drivers/platform/chrome/wilco_ec/sysfs.c +++ b/drivers/platform/chrome/wilco_ec/sysfs.c @@ -192,7 +192,7 @@ static ssize_t usb_charge_show(struct device *dev, if (ret < 0) return ret; - return sprintf(buf, "%d\n", rs.val); + return sysfs_emit(buf, "%d\n", rs.val); } static ssize_t usb_charge_store(struct device *dev,