From: Colin Ian King Date: Thu, 28 May 2020 15:04:27 +0000 (+0100) Subject: RDMA/hns: remove duplicate assignment to pointer raq X-Git-Tag: v5.8-rc1~127^2~26 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=48062b0a8ba0e0d7da2a96fe53028b7474e2dd26;p=linux-block.git RDMA/hns: remove duplicate assignment to pointer raq The pointer raq is being assigned twice. Fix this by removing one of the redundant assignments. Fixes: 14ba87304bf9 ("RDMA/hns: Remove redundant type cast for general pointers") Link: https://lore.kernel.org/r/20200528150427.420624-1-colin.king@canonical.com Addressses-Coverity: ("Evaluation order violation") Signed-off-by: Colin Ian King Signed-off-by: Jason Gunthorpe --- diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c index 8ff6b922b4d7..d02207cd30df 100644 --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c @@ -1146,7 +1146,7 @@ static void hns_roce_db_free(struct hns_roce_dev *hr_dev) static int hns_roce_raq_init(struct hns_roce_dev *hr_dev) { struct hns_roce_v1_priv *priv = hr_dev->priv; - struct hns_roce_raq_table *raq = raq = &priv->raq_table; + struct hns_roce_raq_table *raq = &priv->raq_table; struct device *dev = &hr_dev->pdev->dev; int raq_shift = 0; dma_addr_t addr;