From: Filipe Manana Date: Tue, 16 Jan 2024 15:05:00 +0000 (+0000) Subject: btrfs: remove pointless return value assignment at btrfs_finish_one_ordered() X-Git-Tag: io_uring-6.10-20240523~95^2~89 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=47f694487738af319d0e0fae26c61d77fd6d0c5e;p=linux-block.git btrfs: remove pointless return value assignment at btrfs_finish_one_ordered() At btrfs_finish_one_ordered() it's pointless to assign 0 to the 'ret' variable because if it has a non-zero value (error), we have already jumped to the 'out' label. So remove that redundant assignment. Reviewed-by: Qu Wenruo Signed-off-by: Filipe Manana Reviewed-by: David Sterba Signed-off-by: David Sterba --- diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 12b1a83a4303..1e19cb34b59a 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -3184,7 +3184,6 @@ int btrfs_finish_one_ordered(struct btrfs_ordered_extent *ordered_extent) btrfs_abort_transaction(trans, ret); goto out; } - ret = 0; out: clear_extent_bit(&inode->io_tree, start, end, clear_bits, &cached_state);