From: Alex Deucher Date: Wed, 31 Jul 2019 02:27:03 +0000 (-0500) Subject: drm/amdgpu/powerplay: return success if set_mp1_state is not set X-Git-Tag: for-linus-2019-09-27~66^2~17^2~189 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=479baeacd82841e44cd860d84fa66fe6240f1814;p=linux-2.6-block.git drm/amdgpu/powerplay: return success if set_mp1_state is not set Some asics (APUs) don't have this callback so we want to return success. Avoids spurious error messages on APUs. Reviewed-by: Evan Quan Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c index 88a2ef75b7e1..2e3d9ef625bf 100644 --- a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c +++ b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c @@ -931,12 +931,10 @@ static int pp_dpm_set_mp1_state(void *handle, enum pp_mp1_state mp1_state) if (!hwmgr || !hwmgr->pm_en) return -EINVAL; - if (hwmgr->hwmgr_func->set_mp1_state == NULL) { - pr_info_ratelimited("%s was not implemented.\n", __func__); - return -EINVAL; - } + if (hwmgr->hwmgr_func->set_mp1_state) + return hwmgr->hwmgr_func->set_mp1_state(hwmgr, mp1_state); - return hwmgr->hwmgr_func->set_mp1_state(hwmgr, mp1_state); + return 0; } static int pp_dpm_switch_power_profile(void *handle,