From: Ioana Ciornei Date: Tue, 13 Aug 2019 12:43:01 +0000 (+0300) Subject: staging: fsl-dpaa2/ethsw: remove debug message X-Git-Tag: for-linus-2019-09-27~94^2~145 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=47980a20a4e257c251eee860e5041f16e2313b26;p=linux-2.6-block.git staging: fsl-dpaa2/ethsw: remove debug message Since ethtool will be loud enough if the .set_link_ksettings() callback fails, remove the debug messages which do not add additional information. Reported-by: Andrew Lunn Signed-off-by: Ioana Ciornei Link: https://lore.kernel.org/r/1565700187-16048-5-git-send-email-ioana.ciornei@nxp.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c index 95e9f1096999..12e33a3a1bf1 100644 --- a/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c +++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c @@ -91,8 +91,6 @@ ethsw_set_link_ksettings(struct net_device *netdev, struct dpsw_link_cfg cfg = {0}; int err = 0; - netdev_dbg(netdev, "Setting link parameters..."); - /* Due to a temporary MC limitation, the DPSW port must be down * in order to be able to change link settings. Taking steps to let * the user know that. @@ -116,11 +114,6 @@ ethsw_set_link_ksettings(struct net_device *netdev, port_priv->ethsw_data->dpsw_handle, port_priv->idx, &cfg); - if (err) - /* ethtool will be loud enough if we return an error; no point - * in putting our own error message on the console by default - */ - netdev_dbg(netdev, "ERROR %d setting link cfg", err); return err; }