From: Li Zetao Date: Tue, 3 Sep 2024 14:31:49 +0000 (+0800) Subject: ionic: Remove redundant null pointer checks in ionic_debugfs_add_qcq() X-Git-Tag: v6.12-rc1~232^2~105 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=4614ac219e3f441c64d98d684edbdc8945d49dcc;p=linux-block.git ionic: Remove redundant null pointer checks in ionic_debugfs_add_qcq() Since the debugfs_create_dir() never returns a null pointer, checking the return value for a null pointer is redundant, and using IS_ERR is safe enough. Signed-off-by: Li Zetao Link: https://patch.msgid.link/20240903143149.2004530-1-lizetao1@huawei.com Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c index 59e5a9f21105..c98b4e75e288 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c @@ -123,7 +123,7 @@ void ionic_debugfs_add_qcq(struct ionic_lif *lif, struct ionic_qcq *qcq) struct ionic_cq *cq = &qcq->cq; qcq_dentry = debugfs_create_dir(q->name, lif->dentry); - if (IS_ERR_OR_NULL(qcq_dentry)) + if (IS_ERR(qcq_dentry)) return; qcq->dentry = qcq_dentry;