From: Zhang Qilong Date: Tue, 3 Nov 2020 14:09:47 +0000 (+0800) Subject: spi: spi-ti-qspi: fix reference leak in ti_qspi_setup X-Git-Tag: io_uring-5.11-2020-12-23~68^2^2~49 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=45c0cba753641e5d7c3207f04241bd0e7a021698;p=linux-block.git spi: spi-ti-qspi: fix reference leak in ti_qspi_setup pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to pm_runtime_put_noidle will result in reference leak in ti_qspi_setup, so we should fix it. Fixes: 505a14954e2d7 ("spi/qspi: Add qspi flash controller") Signed-off-by: Zhang Qilong Link: https://lore.kernel.org/r/20201103140947.3815-1-zhangqilong3@huawei.com Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c index 3c41649698a5..9417385c0921 100644 --- a/drivers/spi/spi-ti-qspi.c +++ b/drivers/spi/spi-ti-qspi.c @@ -174,6 +174,7 @@ static int ti_qspi_setup(struct spi_device *spi) ret = pm_runtime_get_sync(qspi->dev); if (ret < 0) { + pm_runtime_put_noidle(qspi->dev); dev_err(qspi->dev, "pm_runtime_get_sync() failed\n"); return ret; }