From: Jens Axboe <axboe@fb.com>
Date: Thu, 21 Jan 2016 04:52:47 +0000 (-0700)
Subject: mutex: fix double unlock in fio_mutex_down_timeout()
X-Git-Tag: fio-2.5~1
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=42e833fa08803ccea6c99df353398a7423845c51;p=fio.git

mutex: fix double unlock in fio_mutex_down_timeout()

In case of error, we unlock twice.

Fixes: 09400a60042e ("mutex: fixup fio_mutex_down_timeout()")
Signed-off-by: Jens Axboe <axboe@fb.com>
---

diff --git a/mutex.c b/mutex.c
index a48e37d0..16107dd4 100644
--- a/mutex.c
+++ b/mutex.c
@@ -136,6 +136,7 @@ int fio_mutex_down_timeout(struct fio_mutex *mutex, unsigned int msecs)
 	if (!ret) {
 		mutex->value--;
 		pthread_mutex_unlock(&mutex->lock);
+		return 0;
 	}
 
 	pthread_mutex_unlock(&mutex->lock);