From: Wei Yongjun Date: Thu, 17 Jun 2021 02:48:37 +0000 (+0000) Subject: scsi: elx: efct: Fix error handling in efct_hw_init() X-Git-Tag: v5.14-rc1~9^2~34 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=41962aba2dc622b456aaf3c20e1089084714f73f;p=linux-block.git scsi: elx: efct: Fix error handling in efct_hw_init() Fix to return negative error code -ENOMEM from the error handling case instead of 0. Also fix typo in error message. Link: https://lore.kernel.org/r/20210617024837.1023069-1-weiyongjun1@huawei.com Fixes: 4df84e846624 ("scsi: elx: efct: Driver initialization routines") Reported-by: Hulk Robot Reviewed-by: James Smart Signed-off-by: Wei Yongjun Signed-off-by: Martin K. Petersen --- diff --git a/drivers/scsi/elx/efct/efct_hw.c b/drivers/scsi/elx/efct/efct_hw.c index ce4736c41564..6324683f9e8e 100644 --- a/drivers/scsi/elx/efct/efct_hw.c +++ b/drivers/scsi/elx/efct/efct_hw.c @@ -1044,8 +1044,8 @@ efct_hw_init(struct efct_hw *hw) */ hw->wq_reqtag_pool = efct_hw_reqtag_pool_alloc(hw); if (!hw->wq_reqtag_pool) { - efc_log_err(hw->os, "efct_hw_reqtag_init failed %d\n", rc); - return rc; + efc_log_err(hw->os, "efct_hw_reqtag_pool_alloc failed\n"); + return -ENOMEM; } rc = efct_hw_setup_io(hw);