From: Arvind Yadav Date: Sat, 2 Dec 2017 17:01:01 +0000 (+0530) Subject: gpio: ftgpio010: Fix platform_get_irq's error checking X-Git-Tag: for-linus-20180210~43^2~49 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=4070a53496ec0c94fda1da0773eee2e5a5bd0084;p=linux-block.git gpio: ftgpio010: Fix platform_get_irq's error checking The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav Signed-off-by: Linus Walleij --- diff --git a/drivers/gpio/gpio-ftgpio010.c b/drivers/gpio/gpio-ftgpio010.c index 7b3394fdc624..b7a3a2db699b 100644 --- a/drivers/gpio/gpio-ftgpio010.c +++ b/drivers/gpio/gpio-ftgpio010.c @@ -176,8 +176,8 @@ static int ftgpio_gpio_probe(struct platform_device *pdev) return PTR_ERR(g->base); irq = platform_get_irq(pdev, 0); - if (!irq) - return -EINVAL; + if (irq <= 0) + return irq ? irq : -EINVAL; ret = bgpio_init(&g->gc, dev, 4, g->base + GPIO_DATA_IN,