From: Paolo Abeni Date: Thu, 29 Jun 2023 10:10:39 +0000 (+0200) Subject: Merge branch 'net-sched-act_ipt-bug-fixes' X-Git-Tag: v6.5-rc1~42^2~32 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=3c4bb45ab29303265a8c6d7099e00c824503c586;p=linux-2.6-block.git Merge branch 'net-sched-act_ipt-bug-fixes' Florian Westphal says: ==================== net/sched: act_ipt bug fixes v3: prefer skb_header() helper in patch 2. No other changes. I've retained Acks and RvB-Tags of v2. While checking if netfilter could be updated to replace selected instances of NF_DROP with kfree_skb_reason+NF_STOLEN to improve debugging info via drop monitor I found that act_ipt is incompatible with such an approach. Moreover, it lacks multiple sanity checks to avoid certain code paths that make assumptions that the tc layer doesn't meet, such as header sanity checks, availability of skb_dst, skb_nfct() and so on. act_ipt test in the tc selftest still pass with this applied. I think that we should consider removal of this module, while this should take care of all problems, its ipv4 only and I don't think there are any netfilter targets that lack a native tc equivalent, even when ignoring bpf. ==================== Link: https://lore.kernel.org/r/20230627123813.3036-1-fw@strlen.de Signed-off-by: Paolo Abeni --- 3c4bb45ab29303265a8c6d7099e00c824503c586