From: Christoph Hellwig <hch@lst.de>
Date: Tue, 24 Jul 2018 12:04:13 +0000 (+0200)
Subject: block: bio_set_pages_dirty can't see NULL bv_page in a valid bio_vec
X-Git-Tag: for-4.19/block-20180812~79
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=3bb5098310317ca62304bd21af6ccea57d799b06;p=linux-2.6-block.git

block: bio_set_pages_dirty can't see NULL bv_page in a valid bio_vec

So don't bother handling it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---

diff --git a/block/bio.c b/block/bio.c
index 504b42278099..07d3ffd95989 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -1636,10 +1636,8 @@ void bio_set_pages_dirty(struct bio *bio)
 	int i;
 
 	bio_for_each_segment_all(bvec, bio, i) {
-		struct page *page = bvec->bv_page;
-
-		if (page && !PageCompound(page))
-			set_page_dirty_lock(page);
+		if (!PageCompound(bvec->bv_page))
+			set_page_dirty_lock(bvec->bv_page);
 	}
 }
 EXPORT_SYMBOL_GPL(bio_set_pages_dirty);